Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First Metal implementation of #110.
next()acquires a drawable and returns an attachment for that frame:Rendering goes straight into the drawable, without private presentation textures or a final blit. Dropping the attachment discards the frame. Recorded and submitted command buffers keep the image alive for as long as they need it.
submit()still commits immediately.present()uses a separate command buffer on the same queue, withpresentDrawablebeforecommit. Acquisition failures throwSwapchainSuboptimal; reset remains explicit.The indexed API remains available for existing callers and the other backends.
Tested with Metal validation on macOS, iOS Simulator and iPhone, including GPU lifetime and pixel readback checks. OpenGothic rendered 1800 frames on both Mac and iPhone, with a swapchain reset.