Conversation
Try
reviewed
Oct 3, 2026
| const size_t roundSize = ((size+64-1)/64)*64; // for uniforms/ssbo structures in msl | ||
|
|
||
| const MTL::ResourceOptions flg = f | MTL::HazardTrackingModeDefault; | ||
| if(data==nullptr) { |
Owner
There was a problem hiding this comment.
maybe keep it with extra check of roundSize == size ?
Basically intent here is leverage fast-driver initialization, if possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer allocations are rounded up to 64 bytes, but
newBuffer(data, roundSize, ...)also copies that many bytes from the source. ASan catches a 64-byte read from the 24-byte data inMetalApi.VboInit.Keep the padded allocation and initialize it through
update(data, 0, size). The same test passes with ASan after this change.