Skip to content

Quieted ghost-admin dev-server noise#28997

Draft
9larsons wants to merge 1 commit into
mainfrom
ghost-admin-dev-noise
Draft

Quieted ghost-admin dev-server noise#28997
9larsons wants to merge 1 commit into
mainfrom
ghost-admin-dev-noise

Conversation

@9larsons

Copy link
Copy Markdown
Contributor

Summary

Three small cleanups that together drop the ghost-admin section of a pnpm dev boot log from ~2031 lines to ~11.

ghost/admin/.ember-cli — Watchman recrawl spam (~800 lines/boot)

Set "watcher": "node" so ember-cli uses Node's native FS watcher instead of Watchman. Watchman's MustScanSubDirs UserDropped recrawl warning trips on every Ember rebuild in this monorepo (Docker bind mounts, Vite-dev module writes) and emits 5-6 lines each time.

Hot reload still works — confirmed by touching ghost/admin/app/router.js and watching Ember rebuild in 1s with zero noise.

ghost/admin/package.jsoncrypto.Hash deprecation (DEP0179, 1 line/boot)

Added NODE_OPTIONS=--disable-warning=DEP0179 to the dev script. The warning comes from an upstream Ember transitive dep, not our code. Scoped to dev only — build and test continue to surface deprecations.

ghost/admin/lib/asset-delivery/index.js — "folder not found" (4 lines/boot)

The post-build hook logged <app> folder not found for each admin-x app whose dist/ was missing. In dev that race is normal — the admin-x apps may not have finished their first build when Ember's first build runs, and Nx triggers another Ember rebuild once they do. Gated the log behind this.env === 'production', where a missing dist/ is a real pipeline failure.

Test plan

  • pnpm dev boot — zero watchman lines, zero DEP0179 lines, zero "folder not found" lines
  • Touch ghost/admin/app/router.js — Ember rebuilds in ~1s via the node watcher
  • pnpm build in ghost/admin (production) — exits 0, asset-delivery hashes all admin-x apps
  • pnpm test in ghost/admin — should be unaffected (.ember-cli watcher key only changes default value, test command still accepts --watcher override)

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23282251-6a34-4a3b-873b-ef5b5f0c6a86

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ghost-admin-dev-noise

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jun 30, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit e9733ff

Command Status Duration Result
nx run @tryghost/admin:build ✅ Succeeded 2m 11s View ↗
nx run ghost-admin:test ✅ Succeeded 2m 26s View ↗
nx run-many -t lint -p ghost-admin ✅ Succeeded 19s View ↗
nx run ghost:build:assets ✅ Succeeded 2s View ↗
nx run ghost:build:tsc ✅ Succeeded 7s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-30 15:05:30 UTC

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 28442953815 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

no ref

- ember-cli now uses Node's native FS watcher instead of Watchman.
  Watchman's MustScanSubDirs recrawl warning fired on every rebuild in
  this monorepo (Docker bind mounts + Vite dev writes), producing ~6
  lines per rebuild and ~800 lines per pnpm dev boot
- ember serve runs with NODE_OPTIONS=--disable-warning=DEP0179 to mute
  the upstream crypto.Hash deprecation warning from an Ember transitive
  dep; scoped to dev only so build/test still surface deprecations
- asset-delivery only logs 'folder not found' for production builds;
  in dev the admin-x apps' dist/ may legitimately be absent on the
  first Ember build (Nx triggers a rebuild once they finish), so the
  warning was noise, not signal

Net effect: pnpm dev boot log drops from ~2031 lines to ~11 for the
ghost-admin section.
@9larsons 9larsons force-pushed the ghost-admin-dev-noise branch from 9890d8e to e9733ff Compare June 30, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant