Quieted ghost-admin dev-server noise#28997
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin:build |
✅ Succeeded | 2m 11s | View ↗ |
nx run ghost-admin:test |
✅ Succeeded | 2m 26s | View ↗ |
nx run-many -t lint -p ghost-admin |
✅ Succeeded | 19s | View ↗ |
nx run ghost:build:assets |
✅ Succeeded | 2s | View ↗ |
nx run ghost:build:tsc |
✅ Succeeded | 7s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-06-30 15:05:30 UTC
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 28442953815 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
no ref - ember-cli now uses Node's native FS watcher instead of Watchman. Watchman's MustScanSubDirs recrawl warning fired on every rebuild in this monorepo (Docker bind mounts + Vite dev writes), producing ~6 lines per rebuild and ~800 lines per pnpm dev boot - ember serve runs with NODE_OPTIONS=--disable-warning=DEP0179 to mute the upstream crypto.Hash deprecation warning from an Ember transitive dep; scoped to dev only so build/test still surface deprecations - asset-delivery only logs 'folder not found' for production builds; in dev the admin-x apps' dist/ may legitimately be absent on the first Ember build (Nx triggers a rebuild once they finish), so the warning was noise, not signal Net effect: pnpm dev boot log drops from ~2031 lines to ~11 for the ghost-admin section.
9890d8e to
e9733ff
Compare

Summary
Three small cleanups that together drop the ghost-admin section of a
pnpm devboot log from ~2031 lines to ~11.ghost/admin/.ember-cli— Watchman recrawl spam (~800 lines/boot)Set
"watcher": "node"so ember-cli uses Node's native FS watcher instead of Watchman. Watchman'sMustScanSubDirs UserDroppedrecrawl warning trips on every Ember rebuild in this monorepo (Docker bind mounts, Vite-dev module writes) and emits 5-6 lines each time.Hot reload still works — confirmed by touching
ghost/admin/app/router.jsand watching Ember rebuild in 1s with zero noise.ghost/admin/package.json—crypto.Hashdeprecation (DEP0179, 1 line/boot)Added
NODE_OPTIONS=--disable-warning=DEP0179to thedevscript. The warning comes from an upstream Ember transitive dep, not our code. Scoped todevonly —buildandtestcontinue to surface deprecations.ghost/admin/lib/asset-delivery/index.js— "folder not found" (4 lines/boot)The post-build hook logged
<app> folder not foundfor each admin-x app whosedist/was missing. In dev that race is normal — the admin-x apps may not have finished their first build when Ember's first build runs, and Nx triggers another Ember rebuild once they do. Gated the log behindthis.env === 'production', where a missingdist/is a real pipeline failure.Test plan
pnpm devboot — zero watchman lines, zero DEP0179 lines, zero "folder not found" linesghost/admin/app/router.js— Ember rebuilds in ~1s via the node watcherpnpm buildinghost/admin(production) — exits 0, asset-delivery hashes all admin-x appspnpm testinghost/admin— should be unaffected (.ember-cliwatcher key only changes default value, test command still accepts--watcheroverride)