Upgraded knex-migrator to remove sqlite3#29011
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis change updates Changes
Possibly related PRs Suggested labels: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 10m | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 42s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
nx run-many -t test:unit -p ghost,@tryghost/adm... |
✅ Succeeded | 6m 7s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 45s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 29s | View ↗ |
nx run ghost-admin:test |
✅ Succeeded | 2m 43s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 1m 55s | View ↗ |
Additional runs (7) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-01 13:49:14 UTC
When the lockfile was regenerated on this branch, transitive codemirror packages (@codemirror/view, @codemirror/commands) floated to versions that pull @codemirror/state@6.7.0, while admin-x-design-system still pinned 6.6.0. The two versions produced incompatible ReactCodeMirrorRef types, breaking the admin-x-settings TypeScript build (and every CI job that depends on it). Collapsing @codemirror/state back to a single 6.6.0 (matching main) resolves it, without churning any other dependencies.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29011 +/- ##
=======================================
Coverage 74.34% 74.35%
=======================================
Files 1565 1565
Lines 135730 135736 +6
Branches 16490 16504 +14
=======================================
+ Hits 100909 100922 +13
- Misses 33795 33815 +20
+ Partials 1026 999 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| # Ghost's migrations build queries with the 2.4.2 query builder and knex-migrator | ||
| # executes them, so its knex must match Ghost's major or the 3.x runner throws on | ||
| # the 2.x builder. Pin it back to 2.4.2 until ghost/core itself moves to knex 3.x. | ||
| 'knex-migrator>knex': 2.4.2 |
There was a problem hiding this comment.
@sam-lord I know we reverted the knex 3 dep in knex-migrator, but I'm wondering if it's worth using peer deps in knex-migrator to make the knex 3 migration a bit easier to do in Ghost directly, rather than requiring a bump in both knex-migrator and Ghost at the same time 🤔

Completely removed the sqlite3 dependency, switching entirely to better-sqlite3 by upgrading to the new release of knex-migrator.