Apply explicit pnpm security baseline to themes - #584
Draft
9larsons wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
minimumReleaseAge: 4320at the monorepo rootstrictDepBuildsandblockExoticSubdepsat the rootpnpm-workspace.yamlfiles that are subtree-pushed into standalone theme repositoriesdtrace-provider: falsedenial everywhereWhy
The root and standalone theme installs previously relied on pnpm defaults for package age, unreviewed lifecycle scripts, and exotic transitive dependency sources. The package-local workspace files are part of the subtree payload, so changing only the monorepo root would leave direct installs and Renovate PRs in standalone theme mirrors without the same policy.
There are no
truebuild permissions in this repository, so this change grants no new lifecycle-script capability and has no version-scoped approvals to add.Impact
Both monorepo and standalone theme installs now:
The next subtree sync will carry the package-local policy to each standalone mirror.
Validation
pnpm@11.19.0 install --frozen-lockfile— verified all 558 lockfile entries against supply-chain policiespnpm build— built all 16 themespnpm test— all 16 themes passed Ghost 6.x compatibility checkspnpm zip --theme tastenpm testinpackages/theme-translations— 8 tests passednpm pack --dry-run --ignore-scriptsfor@tryghost/shared-theme-assetsand@tryghost/theme-translationspackages/tasteoutside the monorepo with no lockfile ornode_modules, then verified:4320,true, andtruepnpm install --no-frozen-lockfilepnpm zippnpm exec gscan --fatal --verbose .Refs PLA-321