fix: Full repo review, bugs, dead code, docs, hardening#3
Merged
Conversation
Ref #2 - Separate SanitizeText from Validate to prevent double-escaping - Fix quoteArg backslash drop on Windows broadcast - Fix broadcast temp file permissions (0644 for cross-session reads) - Fix loadFromArg to accept inline YAML args - Fix ApplyEscalation to pick highest threshold regardless of order - Cap waitForDND at 24h in local mode - Isolate launchSubprocess child with Setsid - Fix deferred timer TOCTOU race in manager - Add DefaultPriority const, move Platform default to ApplyDefaults - Replace deprecated LoadJSON with Load - Compile dayRe once at package level - Remove dead Ping, Classify, init in motd - Fix Enter key targeting dropdown triggers without data-value - Fix docs: motd subcommand, flag scopes, positioning algorithm, deck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate()double-escaping HTML on repeated calls (queue drain path)quoteArgdropping backslashes on Windows broadcastloadFromArgrejecting inline YAML argsApplyEscalationassuming sorted stepswaitForDNDat 24h in local modelaunchSubprocesschild process group from daemon signalsLoadJSONwithLoad(5 call sites)DefaultPriorityconst, movePlatformdefault toApplyDefaultsdayReonce at package levelPing(),Classify(),init()in motd.godata-valueTest plan
go test -race ./internal/... ./cmd/...passes (14 packages)hermes --local 'heading: Test\nmessage: Body'Ref #2
🤖 Generated with Claude Code