Conversation
Updated `RegexRule` to cache the result of regex compilation (including errors) using `OnceLock<Result<Regex, String>>`. This eliminates redundant `Regex::new` calls on every validation. Benchmark results: - Baseline: ~1.58ms per iteration - Optimized: ~2.45µs per iteration - Speedup: ~645x Co-authored-by: Tuntii <121901995+Tuntii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR optimizes the RegexRule validation by caching both successful and failed regex compilation results. Previously, the code cached only successful compilations (with a fallback pattern) and re-compiled the regex on every validation call to check for errors, causing significant overhead.
Changes:
- Modified
RegexRule.compiledfield type fromOnceLock<Regex>toOnceLock<Result<Regex, String>>to cache both success and error cases - Refactored
get_regex()method to properly handle and cache compilation errors without redundant regex compilation
| fn get_regex(&self) -> Result<&Regex, RuleError> { | ||
| self.compiled.get_or_init(|| { | ||
| Regex::new(&self.pattern).unwrap_or_else(|_| Regex::new("^$").unwrap()) | ||
| let result = self.compiled.get_or_init(|| { | ||
| Regex::new(&self.pattern) | ||
| .map_err(|_| format!("Invalid regex pattern: {}", self.pattern)) | ||
| }); | ||
|
|
||
| // Verify the pattern is valid | ||
| if Regex::new(&self.pattern).is_err() { | ||
| return Err(RuleError::new( | ||
| "regex", | ||
| format!("Invalid regex pattern: {}", self.pattern), | ||
| )); | ||
| match result { | ||
| Ok(regex) => Ok(regex), | ||
| Err(msg) => Err(RuleError::new("regex", msg.clone())), | ||
| } | ||
|
|
||
| Ok(self.compiled.get().unwrap()) | ||
| } |
There was a problem hiding this comment.
The error handling path for invalid regex patterns is not covered by tests. Consider adding a test case that validates the behavior when an invalid regex pattern is provided, such as a pattern with unbalanced brackets. This would ensure that the new error caching logic works correctly and that the error message is properly formatted and returned.
1 participant
Updated
RegexRuleto cache the result of regex compilation (including errors) usingOnceLock<Result<Regex, String>>. Previously, it only cached the success case and re-compiled the regex on every validation call to check for errors.The redundant regex compilation caused significant overhead. The optimization eliminates the expensive
Regex::newparsing and compilation step from the hot path of validation.Benchmark showed a massive performance improvement (from ~1.58ms to ~2.45µs per iteration).
PR created automatically by Jules for task 3847355307570598131 started by @Tuntii