Conversation
mfedderly
left a comment
mfedderly
left a comment
There was a problem hiding this comment.
Note I did have to revert sweepline-intersections back to 1.5.0.
Hopefully this sets a baseline which lets us mass upgrade the world periodically and not have to fiddle with managing upgrades one at a time. pnpm also has a setting that lets us skip taking upgrades within N minutes, if we'd like.
| "no-redeclare": "off", | ||
| "no-var": "off", | ||
| "prefer-const": "off", | ||
| "no-useless-assignment": "off", // the remaning errors here require more thought to clean up |
There was a problem hiding this comment.
The "fix" is to go from let x = 0 to just let x (or similar). There's <10 errors from this, but I'm afraid to make those changes without thinking about things more closely.
|
Setting to draft for node support, perhaps we can get to this in v8 milestone instead. |
mfedderly
force-pushed
the
mf/pnpm-upgrade-everything
branch
from
02c7468 to
5d63056
Compare
| const f = Math.pow(10, 9); | ||
| const props: (keyof typeof d.properties)[] = [ | ||
| "cartesianAngle", | ||
| "bearingAngle", | ||
| "circularVariance", | ||
| ]; | ||
|
|
||
| for (const k of props) { | ||
| d.properties[k] = Math.round(d.properties[k] * f) / f; | ||
| } |
There was a problem hiding this comment.
Really don't love this section and how I arbitrarily started passing tests with 9 digits after the decimal, but 10 didn't work.
1 participant
Ran
pnpm upgrade -r --latestto yoink everything to the newest version around.This required several manual fixes included in the 2nd commit.