-
-
Notifications
You must be signed in to change notification settings - Fork 776
feat!: rebuild version history and customize snapshot actions #3090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nperez0111
wants to merge
62
commits into
main
Choose a base branch
from
feat/versioning-sidebar-ux-b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16,300
−6,202
Open
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
b7d78ae
feat(core): add composable read-only restrictions
nperez0111 72a1702
feat(core)!: refine attribution colors and deleted-block styling
nperez0111 621902e
refactor(core)!: unify versioning state and preview lifecycle
nperez0111 11b4d59
feat(react)!: rebuild the version history sidebar
nperez0111 9be8d14
chore(examples): refresh versioning demos and setup
nperez0111 f2857ad
Improve versioning sidebar menu customization
nperez0111 f8ecfc9
Polish suggestion gallery styling and expand versioning coverage
nperez0111 194f69f
Fix build and snapshot runner dependency conflicts
nperez0111 48bec82
Fix version history seeding retries and preview state
nperez0111 a82f062
refactor: unify editability in ReadOnly extension
nperez0111 9cb2b5b
fix: animate versioning highlights without DOM mutations
nperez0111 b60ac63
Upgrade Yjs and y-prosemirror
nperez0111 2f9b255
Add attribution for block property changes
nperez0111 e4a5779
Improve version history keyboard accessibility and remove Save action
nperez0111 459b4db
Refactor YHub versioning and add safe history refresh
nperez0111 10062b6
Fix YHub attribution bounds for current version previews
nperez0111 449b9c5
Require synchronous version previews and simplify adapter contracts
nperez0111 e754cb6
Keep version selection visible when deletion clears a name
nperez0111 72fd1e5
Share versioning UI primitives and simplify sidebar state
nperez0111 c7fe526
Deduplicate versioning example history fixtures
nperez0111 afec519
refactor(react): move versioning to a dedicated sub-export
nperez0111 c9bc61b
fix: use read-only
nperez0111 6105796
chore: yjs versions
nperez0111 e537940
refactor: simplify
nperez0111 4dd8c83
refactor: inline version history sidebar, default editable true, use …
nperez0111 6939146
refactor: simplify scrollToFirstChange
nperez0111 26312d6
refactor: i18n versionLabel via blocknote dictionary
nperez0111 60fbd84
fix(core): report ReadOnly state from isEditable while unmounted
nperez0111 c492792
refactor(react): fixed header over scrolling version list, drop focus…
nperez0111 2f583c7
fix(react): return to Current when deleted version leaves the list
nperez0111 4a26842
chore: rm
nperez0111 8aa535a
fix(react): dedupe generic formatting-change tooltip label
nperez0111 ad01251
docs(gallery): mark textcolor-vs-bgcolor prop attribution as resolved
nperez0111 b93aa89
fix(core): stable empty-doc binding in new y/ collab stack
nperez0111 ba4e246
refactor(core): split y snapshot preview into codec + render modules
nperez0111 f96a8a6
refactor(core): drop yhub restore refresh delay, guard empty doc
nperez0111 1ce3379
refactor(core): rework Versioning list/preview sessions, add sub-modu…
nperez0111 44ffe1c
fix(core): flatten legacy anonymous text nodes when diffing snapshots
nperez0111 15ec810
test(e2e): refresh snapshots for pristine empty docs and trailing block
nperez0111 3c5ee8a
refactor(core): render version diffs without clearing the document
nperez0111 b29be57
refactor(versioning): derive loading state instead of storing it
nperez0111 ae21c0b
refactor(core): render version diffs via patched @y/prosemirror fragm…
nperez0111 bffcb7a
refactor(core): gate empty-doc sync via initialContentCompare instead…
nperez0111 32463db
fix(core): re-anchor initial-content gate when the empty skeleton is …
nperez0111 a38ba03
fix(tests): isPristineEmptyEditor ignores skeleton block ids
nperez0111 e2d5fbc
refactor(versioning): remove unused review leftovers and clarify refs
nperez0111 784de3a
fix(core): update YHub activity grouping API
nperez0111 46605aa
feat(versioning): refine sidebar skins and naming
nperez0111 32197f9
fix(core): reconcile version preview attribution
nperez0111 43e2f6f
Merge remote-tracking branch 'origin/feat/versioning-sidebar-ux-b' in…
nperez0111 2170aa7
Merge remote-tracking branch 'origin/main' into feat/versioning-sideb…
nperez0111 85734d9
fix: stabilize experimental yjs13 versioning
nperez0111 10082b8
docs(examples): restore unresolved suggestion feedback
nperez0111 206d4be
fix(examples): wire suggestion multi-editor mode
nperez0111 fa085bd
test(react): colocate browser UI tests
nperez0111 155d256
fix(versioning): localize version labels
nperez0111 616f23a
fix(versioning): keep sidebar menus visible
nperez0111 60a6a3a
Merge remote-tracking branch 'origin/main' into feat/versioning-sideb…
nperez0111 7db8d83
refactor(react): simplify attribution tooltip reference
nperez0111 57020b3
chore: remove y-prosemirror patch
nperez0111 ca3de6a
test: update concurrent formatting snapshot
nperez0111 12d669c
fix(react): forward client rects to floating references
nperez0111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
examples/07-collaboration/11-versioning-yjs13/.bnexample.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| { | ||
| "playground": true, | ||
| "docs": true, | ||
| "docs": false, | ||
| "author": "yousefed", | ||
| "tags": ["Advanced", "Development", "Collaboration"], | ||
| "dependencies": { | ||
| "y-websocket": "^2.1.0", | ||
| "yjs": "^13.6.27", | ||
| "lib0": "^0.2.99" | ||
| "lib0": "^0.2.99", | ||
| "y-prosemirror": "^1.3.7" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
examples/07-collaboration/11-versioning-yjs13/src/SettingsSelect.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this demo (suggestion-multi-editor) is now completely broken. Either fix or remove?