Add workspace symbol feature#85
Merged
Merged
Conversation
ssmifi
force-pushed
the
ssm/workspace-symbols
branch
from
870ee8a to
dce584e
Compare
msujew
reviewed
Jun 2, 2026
msujew
left a comment
msujew
left a comment
Member
There was a problem hiding this comment.
Thanks a lot! I think that it would make sense to reuse the fuzzy matching service implemented in the completion PR. That way, we don't have to maintain multiple fuzzy matching implementations.
ssmifi
force-pushed
the
ssm/workspace-symbols
branch
from
dce584e to
138cf1a
Compare
Collaborator
Author
|
Thanks for the review. Also uses the fuzzy matcher service now. I moved my fuzzy tests over, but if you think they are too much, I can remove them. |
msujew
approved these changes
Jun 15, 2026
msujew
left a comment
msujew
left a comment
Member
There was a problem hiding this comment.
Thanks, looks good to me. Just one minor improvements to the tests, see below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
and implements the workspace symbol provider, which is basically a port from Langium.
Customization is aligned to the recent providers.
There is also a suggestion to include a max symbol count, but we can drop if desired.
Also, I noticed that the completion service added fuzzy matcher as a service. In this approach similar to before I tried to simplify the interface and just added a fuzzy function with the same functionality as a suggestion. But I can reuse the matcher, if you think it is worth it in the long run.