fixes #326; build with python -m build instead of deprecated python setup.py sdist bdist_wheel - #346
Merged
dave-doty merged 1 commit intoAug 10, 2026
Conversation
…n setup.py sdist bdist_wheel` Invoking setup.py directly is deprecated, so this job was on a clock: whenever setuptools removes the setup.py command interface, it starts failing on setuptools' schedule rather than ours. `python -m build` is the standard PEP 517 front end and produces the same sdist and wheel in an isolated build environment. It is also what release.yml, the workflow that actually publishes to PyPI, already uses; having the workflow meant to *check* packaging build differently from the one that performs it somewhat defeated the point of the check. Verified locally in a clean virtualenv: `python -m build` against the current setup.py produces scadnano-0.21.1.tar.gz and scadnano-0.21.1-py3-none-any.whl, with the wheel containing __init__.py, scadnano.py, modifications.py and origami_rectangle.py. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dave-doty
deleted the
326-use-python-m-build-instead-of-deprecated-setup-py
branch
August 10, 2026 17:06
dave-doty
added a commit
that referenced
this pull request
Aug 10, 2026
…ject-toml #346 landed the same switch to `python -m build` in check_pypi_packaging.yml that this branch already contained. Those two lines merged cleanly; the conflict was only that this branch appends the wheel smoke-test step immediately after them, so the hunks overlapped. Resolved in favour of this branch, whose version of the file is a superset: identical build step, plus the smoke test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326.
check_pypi_packaging.ymlbuilt the package by invokingsetup.pydirectly, which is deprecated. It works today, but on setuptools' schedule rather than ours: whenever thesetup.pycommand interface is finally removed, the job starts failing.python -m buildis the standard PEP 517 front end and produces the same sdist and wheel in an isolated build environment. It is also whatrelease.yml— the workflow that actually publishes to PyPI — already uses, so this makes the workflow that checks packaging build the same way as the one that performs it.Verification
Ran
python -m buildin a clean virtualenv against the currentsetup.py: producesscadnano-0.21.1.tar.gzandscadnano-0.21.1-py3-none-any.whl, with the wheel containing__init__.py,scadnano.py,modifications.pyandorigami_rectangle.py.Relationship to #344
#344 deletes
setup.pyentirely, so it must make this same change — this two-line diff is contained in that PR as well. Both branches change the same two lines to the same content, so they merge cleanly in either order, and merging #344 alone would also close #326.This is here as the small, independently reviewable piece; take whichever path you prefer.
🤖 Generated with Claude Code