portfolio: refactor caching - and add cron to write cache#23
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Project Portfolio Google Sheet integration by introducing a shared caching service and adding an Ultimate Cron job to warm that cache, so sheet fetches happen off the request-render path while still allowing a cold-miss fallback.
Changes:
- Add
PortfolioDataservice to centralize fetch + cache write/refresh behavior (including tag invalidation on refresh). - Update
PortfolioBlockto use the new service and emit cache metadata (tag + max-age) for downstream caches. - Add an Ultimate Cron job and callback to refresh the cache on a schedule, plus unit tests for the new service.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/Services/PortfolioData.php |
New service providing shared fetch/cache + refresh/tag invalidation. |
src/Plugin/Block/PortfolioBlock.php |
Switches block to DI + uses oit.portfolio service; adds cache tag/max-age. |
src/Services/CronManager.php |
Adds cron callback to refresh portfolio cache (live env only). |
oit.services.yml |
Registers oit.portfolio service with cache + tag invalidator dependencies. |
config/install/ultimate_cron.job.portfolio_refresh.yml |
Adds scheduled Ultimate Cron job to warm the portfolio cache. |
tests/src/Unit/Services/PortfolioDataTest.php |
Adds unit tests covering cache-hit/miss and refresh behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.