Skip to content

fix(ui5-rating-indicator): import default icons #13824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndeshev wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −0
Open

fix(ui5-rating-indicator): import default icons #13824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b9f937
fix(ui5-rating-indicator): import default icons
ndeshev Jul 14, 2026
388fa1c
fix(ui5-rating-indicator): import default icons
ndeshev Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/main/cypress/specs/RatingIndicator.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,34 @@ import "@ui5/webcomponents-icons/dist/thumb-up.js";
import "@ui5/webcomponents-icons/dist/thumb-down.js";

describe("RatingIndicator", () => {
Comment thread
ndeshev marked this conversation as resolved.
describe("Default Icons Loading", () => {
it("should load and render the default 'favorite' and 'unfavorite' icons without explicit imports", () => {
cy.mount(<RatingIndicator value={3}></RatingIndicator>);

cy.get("[ui5-rating-indicator]")
.shadow()
.find(".ui5-rating-indicator-item-sel [ui5-icon]")
.first()
.shadow()
.find("svg path[d]")
.should("exist")
.and($path => {
expect($path.attr("d")).to.have.length.greaterThan(0);
});

cy.get("[ui5-rating-indicator]")
.shadow()
.find(".ui5-rating-indicator-item-unsel [ui5-icon]")
.first()
.shadow()
.find("svg path[d]")
.should("exist")
.and($path => {
expect($path.attr("d")).to.have.length.greaterThan(0);
});
});
});

describe("Custom Icons", () => {
it("should render default icons when no custom icons are specified", () => {
cy.mount(<RatingIndicator value={3}></RatingIndicator>);
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/RatingIndicator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import {
import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/AccessibilityTextsHelper.js";
import i18n from "@ui5/webcomponents-base/dist/decorators/i18n.js";
import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
import "@ui5/webcomponents-icons/dist/favorite.js";
import "@ui5/webcomponents-icons/dist/unfavorite.js";
import {
RATING_INDICATOR_TEXT,
RATING_INDICATOR_TOOLTIP_TEXT,
Expand Down
Loading