Skip to content

fix(ui5-multi-combobox): toggle 'select all' checkbox correctly with grouped suggestions #13827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndeshev wants to merge 1 commit into
base: main
Choose a base branch
from
+106 −8
Open

fix(ui5-multi-combobox): toggle 'select all' checkbox correctly with grouped suggestions #13827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions packages/main/cypress/specs/MultiComboBox.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5503,3 +5503,90 @@ describe("MultiComboBoxItemCustom - Mixed Selection", () => {
cy.get("@multiCombobox").shadow().find("[ui5-token]").should("have.length", 2);
});
});

describe("Select All with Groups", () => {
it("should check the 'select all' checkbox when all items in groups are selected", () => {
cy.mount(
<MultiComboBox showSelectAll={true}>
<MultiComboBoxItemGroup headerText="Group 1">
<MultiComboBoxItem text="Item 1"></MultiComboBoxItem>
<MultiComboBoxItem text="Item 2"></MultiComboBoxItem>
</MultiComboBoxItemGroup>
<MultiComboBoxItemGroup headerText="Group 2">
<MultiComboBoxItem text="Item 3"></MultiComboBoxItem>
<MultiComboBoxItem text="Item 4"></MultiComboBoxItem>
</MultiComboBoxItemGroup>
</MultiComboBox>
);

cy.get("[ui5-multi-combobox]")
.as("mcb")
.shadow()
.find(".inputIcon")
.realClick();

cy.get("@mcb")
.shadow()
.find<ResponsivePopover>("ui5-responsive-popover")
.as("popover")
.ui5ResponsivePopoverOpened();

cy.get("@popover")
.find(".ui5-mcb-select-all-checkbox")
.as("selectAllCheckbox")
.should("not.have.attr", "checked");

cy.get("@selectAllCheckbox")
.realClick();

cy.get("@selectAllCheckbox")
.should("have.attr", "checked");

cy.get("@mcb")
.shadow()
.find("[ui5-tokenizer]")
.find("[ui5-token]")
.should("have.length", 4);
});

it("should uncheck the 'select all' checkbox when deselecting one item in a group", () => {
cy.mount(
<MultiComboBox showSelectAll={true}>
<MultiComboBoxItemGroup headerText="Group 1">
<MultiComboBoxItem text="Item 1" selected={true}></MultiComboBoxItem>
<MultiComboBoxItem text="Item 2" selected={true}></MultiComboBoxItem>
</MultiComboBoxItemGroup>
<MultiComboBoxItemGroup headerText="Group 2">
<MultiComboBoxItem text="Item 3" selected={true}></MultiComboBoxItem>
<MultiComboBoxItem text="Item 4" selected={true}></MultiComboBoxItem>
</MultiComboBoxItemGroup>
</MultiComboBox>
);

cy.get("[ui5-multi-combobox]")
.as("mcb")
.shadow()
.find(".inputIcon")
.realClick();

cy.get("@mcb")
.shadow()
.find<ResponsivePopover>("ui5-responsive-popover")
.as("popover")
.ui5ResponsivePopoverOpened();

cy.get("@popover")
.find(".ui5-mcb-select-all-checkbox")
.as("selectAllCheckbox")
.should("have.attr", "checked");

cy.get("[ui5-mcb-item]")
.first()
.shadow()
.find("[ui5-checkbox]")
.realClick();

cy.get("@selectAllCheckbox")
.should("not.have.attr", "checked");
});
});
5 changes: 3 additions & 2 deletions packages/main/src/MultiComboBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1862,8 +1862,9 @@ class MultiComboBox extends UI5Element implements IFormInputElement {

if (this.open) {
const list = this._getList();
const selectedListItemsCount = this.items.filter(item => item.selected).length;
this._allSelected = selectedListItemsCount > 0 && ((selectedListItemsCount === this.items.length) || (list?.getSlottedNodes("items").length === selectedListItemsCount));
const selectableItems = this._getItems().filter(item => !item.isGroupItem);
const selectedListItemsCount = selectableItems.filter(item => item.selected).length;
this._allSelected = selectedListItemsCount > 0 && ((selectedListItemsCount === selectableItems.length) || (list?.getSlottedNodes("items").length === selectedListItemsCount));
}

this._effectiveShowClearIcon = (this.showClearIcon && !!this.value && !this.readonly && !this.disabled);
Expand Down
22 changes: 16 additions & 6 deletions packages/main/src/themes/MultiComboBoxPopover.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,21 @@
top: 0;
z-index: 2;
background: var(--sapPageHeader_Background);
box-sizing: border-box;
}

.ui5-mcb-select-all-header:focus,
.ui5-mcb-select-all-header:focus-within {
outline: none;
}

.ui5-mcb-select-all-header:focus::after,
.ui5-mcb-select-all-header:focus-within::after {
content: "";
position: absolute;
inset: 2px;
border: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
pointer-events: none;
}

.ui5-mcb-select-all-checkbox {
Expand All @@ -17,12 +32,7 @@
}

.ui5-mcb-select-all-checkbox::part(root):focus::before {
border: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
border-radius: 0;
right: 2px;
left: 2px;
bottom: 0;
top: 0;
display: none;
}

.ui5-mcb-select-all-checkbox::part(label) {
Expand Down
Loading