Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add native playthrough-scoped records and opaque bytes for API 3, with a title-only storage:selected(game) facade. API-1/2 mods now also receive selected(game), delegated lazily to that same native service. Their existing installation-wide read/write/byte methods, paths and signatures remain unchanged; no automatic migration guesses which save owns an old shared payload.
The service provides detached context/data records, sorted keys, typed-key conflicts, verified staging/backup recovery and opaque identities allocated without gameplay RNG. Normal saves, legacy slot promotion, duplicate imports, failed writes and title/init ownership retain the existing identity contracts. The added legacy method creates its private delegate once, without changing the original storage namespace.
Depends on #154 and the preceding portability series. The original feature comparison remains 5ed6353...aef5650. The API-1/2 extension is isolated at 0740821, with the dependency-attribution correction at fefd080. Merge prerequisites first and rebase before integration. docs/api3-storage.md documents the base storage contract.
Validation:
FrameProfile before/after: not measured. This is an additive compatibility service; no performance switch applies. Hosted workflows require maintainer approval; local results above do not establish a new hosted pass.
Original additions by Roxas2712 are offered to Cedric / UNDERdecoded under the specific PR contribution permission at https://github.com/Roxas2712/Gen2Recomped/blob/4fb81fbf/LICENSE-ROXAS2712.md, with visible contributor credit. Existing rights, notices, credits and earlier permissions remain effective.
Current upstream qualification
Merged
8d5b4387; runtime91f14c97passes 120/120 engine suites and all SDK suites. The native supersample draw keeps the existing screen-visibility admission; both visibility suites also pass directly. This earlier standalone dependency host retains the inherited missing gallery files and lacks later contract/external-fixture runners; complete five-gate compatibility is qualified on the composed fork and P9 stack (#323). Existing repair commits #128–#134 and #294 are reused.