Skip to content

Connect native GSC flight queries and fix regional map decoding - #257

Closed
Roxas2712 wants to merge 38 commits into
UNDERdecoded:mainfrom
Roxas2712:codex/upstream-gen2-fly-destinations
Closed

Roxas2712 wants to merge 38 commits into
UNDERdecoded:mainfrom
Roxas2712:codex/upstream-gen2-fly-destinations

Conversation

@Roxas2712

@Roxas2712 Roxas2712 commented Oct 25, 2026 •

Copy link
Copy Markdown

GSC's native TownMap flight picker builds its own visited-map list, so a legacy FieldMoves.flyPoints wrapper never reaches the actual selection controller. A stale visited-map fallback can also undo an explicit native script clear.

Add native FLYPOINTS, KANTO_FLYPOINT, hasVisitedSpawn and flyPoints queries, with Crystal's inserted engine-flag row resolved through the actual script VM flag namespace. The native picker consumes the public query and preserves imported landing coordinates and proven map identities. Default regional queries retain the Indigo gate; real mod wrappers can supply combined regional lists. No duplicate visited write, cartridge layout guess for other games, private mod/assets or mod-specific condition is added.

Prerequisites / review delta

This topic is stacked on #243 at b9c0545a, including its native camera/state-query prerequisites. Review the new flight delta separately: https://github.com/Roxas2712/Gen2Recomped/compare/b9c0545a...18197584

The standalone Gen2 MapIdentity reader is included byte-for-byte from #211 (3aa7017f). Complete shared-map alias production remains in #211; no fork Gen3 naming adapter, launcher/release policy or contribution-notice packaging change is copied here. Integrating #243/#211 should retain their existing facade/helper and apply this flight delta.

Validation

  • This upstream composition passes 149 focused checks: real native VM set/clear execution, Gold/Silver/Crystal numbering, explicit-clear precedence, previous-save fallbacks, registered aliases, regional gates, actual TownMap A/B selection/cancellation, real SDK query wrapping and actual loader teardown.
  • Existing field-state suite: 30 checks pass.
  • Full-image ROM-free town-map importer regression: 36 checks pass, including all 23,040 pixels of both regional fixtures across G/S/C. The frozen previous importer fails the six image assertions; no cartridge content is included. Retail G/S/C compressed town-map graphics now decode before pixels, with scoped cache invalidation and explicit raw-layout overrides retained. Crystal’s Silver Cave region follows the native Pallet-header boundary.
  • Fresh frozen ROM-free quick comparison: prerequisite b9c0545a passes 81/91 engine suites; current feature 18197584 passes 83/93. Both have exactly the same ten failed suites and identical reported failure assertions; SDK 3/3 passes in both. The two added suites (flight and complete-image pixel import) pass, with no additional failed suite. Existing prerequisite failures remain unaccepted. The existing baseline failures are not reported as green.
  • Fork validation and packaged GPU receipts are separate compositions and do not qualify this upstream topic.

Live Crystal flight/arrival and complete unchanged-mod cinematic/Hall-of-Fame expectations remain unaccepted. This does not add the legacy field-action result protocol or claim complete feature parity.

Contribution permission / provenance

Only independently owned new contributions are offered under the specific Cedric / UNDERdecoded permission in https://github.com/Roxas2712/Gen2Recomped/blob/7867399c753186778bd4b8816ba37573357e4b40/LICENSE-ROXAS2712.md and the accompanying https://github.com/Roxas2712/Gen2Recomped/blob/7867399c753186778bd4b8816ba37573357e4b40/NOTICE.md . Preserve all applicable upstream/third-party rights and earlier grants. This is not a claim of ownership of entire pre-existing files. Consolidated visible credit: Contributions by Roxas2712 — https://github.com/Roxas2712 .

Maarten Paus added 30 commits October 25, 2026 01:12
@Roxas2712 Roxas2712 changed the title Connect native GSC flight destination queries to the actual picker Connect native GSC flight queries and fix regional map decoding Oct 25, 2026
@Roxas2712 Roxas2712 closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant