Repository navigation
Conversation
added 30 commits
October 25, 2026 01:12
…dering acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GSC's native TownMap flight picker builds its own visited-map list, so a legacy
FieldMoves.flyPointswrapper never reaches the actual selection controller. A stale visited-map fallback can also undo an explicit native script clear.Add native
FLYPOINTS,KANTO_FLYPOINT,hasVisitedSpawnandflyPointsqueries, with Crystal's inserted engine-flag row resolved through the actual script VM flag namespace. The native picker consumes the public query and preserves imported landing coordinates and proven map identities. Default regional queries retain the Indigo gate; real mod wrappers can supply combined regional lists. No duplicate visited write, cartridge layout guess for other games, private mod/assets or mod-specific condition is added.Prerequisites / review delta
This topic is stacked on #243 at
b9c0545a, including its native camera/state-query prerequisites. Review the new flight delta separately: https://github.com/Roxas2712/Gen2Recomped/compare/b9c0545a...18197584The standalone Gen2
MapIdentityreader is included byte-for-byte from #211 (3aa7017f). Complete shared-map alias production remains in #211; no fork Gen3 naming adapter, launcher/release policy or contribution-notice packaging change is copied here. Integrating #243/#211 should retain their existing facade/helper and apply this flight delta.Validation
b9c0545apasses 81/91 engine suites; current feature18197584passes 83/93. Both have exactly the same ten failed suites and identical reported failure assertions; SDK 3/3 passes in both. The two added suites (flight and complete-image pixel import) pass, with no additional failed suite. Existing prerequisite failures remain unaccepted. The existing baseline failures are not reported as green.Live Crystal flight/arrival and complete unchanged-mod cinematic/Hall-of-Fame expectations remain unaccepted. This does not add the legacy field-action result protocol or claim complete feature parity.
Contribution permission / provenance
Only independently owned new contributions are offered under the specific Cedric / UNDERdecoded permission in https://github.com/Roxas2712/Gen2Recomped/blob/7867399c753186778bd4b8816ba37573357e4b40/LICENSE-ROXAS2712.md and the accompanying https://github.com/Roxas2712/Gen2Recomped/blob/7867399c753186778bd4b8816ba37573357e4b40/NOTICE.md . Preserve all applicable upstream/third-party rights and earlier grants. This is not a claim of ownership of entire pre-existing files. Consolidated visible credit: Contributions by Roxas2712 — https://github.com/Roxas2712 .