Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine loads connected maps natively, but source renderers cannot discover the same graph through the live world: the map/tileset registries and resident neighbor identities are missing. When a source renderer attaches a presentation-only Map to a neighbor, the native fallback also assumes that view owns native drawing methods and can crash at
drawMapOnly.Publish the actual map/tileset registries, IDs, pixel offsets and cell offsets on the existing resident records. Keep native ground and upper-layer drawing on the loader-owned resident map, rebuilding a missing native resource through the loader when needed. Borrowed presentation views remain intact. The existing native BFS and protected residency set still own map loading and coordinate placement.
Validation on head
2ff1805c: 330/330 focused assertions across Red, Yellow, Gold, Crystal, Emerald and FireRed, plus the draw fixture’s Platinum case. Covers traversal, negative offsets, GB 32-pixel/GBA 16-pixel blocks, dataset replacement, real native draw calls, a declining source pipeline, upper-layer ownership, resource reload and custom-neighbor fallback. Fixtures are synthetic and contain no cartridge or private mod data. The earlier broader comparison at head350b3626retained 11 existing failing upstream suites; that whole comparison was not repeated for this renderer fix, so this is a focused validation claim.The development fork separately passes 15,330 related identity/lifecycle/draw checks and a natural Crystal introduction→starter→map connection→wild battle with an unchanged private mod on Metal. Internal framebuffers show the restored tree backdrop in first/third camera observations and zero missing-dependency fallbacks; the desktop was locked, so this is not OS-window or final-package qualification. Publishing physical map aliases also requires consistent connection target IDs; the fork-specific alias-owner correction is shown in fork PR #166.
Original contributions by Roxas2712 are offered under the included
LICENSE-ROXAS2712.md, including Cedric / UNDERdecoded’s specific integration permission with visible credit. Existing upstream and third-party rights and credits remain intact. No ROMs, private mods, artwork, profiles or saves are included.