Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen1Recomp source clients navigate Gen2 OPTION using grouped
visible()rows, child pages andfocusRow, while the shared native screen exposes only a flat list. That changes both the menu hierarchy and the cursor contract in unchanged source presentations.Add SPEED, VIDEO, GRAPHICS, AUDIO, BATTLE OPTIONS and EXTRAS views over the existing native row objects. Flat hook rows, native setters, actual option storage and unknown authored rows remain available; child pages return to their parent and only the root calls the caller completion/cancel callbacks. Left reverses the native text-speed ladder. Gen1/Gen3 keep their established flat presentation.
Based on current upstream
8d5b4387420cc1fdcadf58ad4ca78a7d8596e41d. On head98853a30, all 121 new Gold/Silver/Crystal grouping/navigation/persistence assertions, 20 UI-layout and 23 battle-fit assertions pass. Related fork development testing reaches all six pages using normal input with an unchanged source mod; this is not full upstream gameplay/GPU or whole-engine parity qualification. No private mod, ROM, art, profile or save is included.The group vocabulary/order follows Gen1Recomp reference
535a5ec0(src/ui/gen2/OptionsMenu.lua); original project rights remain applicable. Roxas2712 retains rights to his own contributions and expressly offers the covered contributions to Cedric / UNDERdecoded under the includedLICENSE-ROXAS2712.md, preserving applicable earlier licenses. Requested visible credit: Contributions by Roxas2712 — https://github.com/Roxas2712. Existing third-party credits remain intact.Follow-up on
c8599404: group children now go through the public constructor’s explicitrowsform, allowing native per-instance presentation wrappers to reach each child without rebuilding root hooks. Independent validation on this upstream branch passes349 grouped-menu,20 UI-layout and23 battle-fit checks (392 total), including actual constructor/row/input/parent ownership and empty explicit pages. The fork’s additional window-resolution renderer depends on the native UI foundation offered separately in PR271; this minimal PR does not claim that composition capability or upstream GPU qualification.