Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared native NEW GAME callback enters the Gen2 home map before clock/name selection. Gen1Recomp's Gen2 lifecycle creates its world after that introduction. A source client's required destination-preparation cover can consequently wait for a home-map draw while it still owns input above the hidden introduction.
Defer only Gen2 world creation to the configured introduction's real completion callback. Read the adopted save's final position at completion; duplicate completion and a callback retained from an abandoned save cannot create a second/stale world. Gen1 and datasets with no introduction keep immediate world creation. Save adoption, save.created and native input/intro ownership remain in their original owners. No supplied mod is changed.
Based on current upstream
8d5b4387420cc1fdcadf58ad4ca78a7d8596e41d; all 52 focused Gold/Silver/Crystal lifecycle assertions pass on518890f0, including no-intro datasets, duplicate/stale completion and unchanged Gen1 creation order. Related fork development testing confirms actual natural Crystal NEW GAME no longer stalls under an unchanged source mod in Metal. This does not qualify whole upstream gameplay, every introduction implementation or full visual parity. No ROM, private mod/art, profile or save is included.Roxas2712 retains rights to his own contributions and expressly offers the covered contributions to Cedric / UNDERdecoded under the included
LICENSE-ROXAS2712.md, preserving applicable earlier licenses and third-party credits. Requested visible credit: Contributions by Roxas2712 — https://github.com/Roxas2712.