Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting SHINY ODDS → DEFAULT after ALWAYS removed the key from the live options table. The generation-aware options writer then retained the previous on-disk rate, so a fresh load could enable the extra shiny roll again. Store an explicit zero for DEFAULT; Pokemon.shinyOddsOf already treats zero as the cartridge rate.
The regression drives the upstream flat menu through its normal input and the real saveOptions/optionsFor persistence path. It covers Red, Gold, Silver, Crystal and Emerald, shared values and per-generation overrides, and preservation of shared/other-generation settings.
Validation on 4a988e2: 130/130 persistence assertions, 20/20 UI-layout assertions and 23/23 battle-fit assertions pass. No ROM, mod data, GPU or release qualification is included.
Contributions by Roxas2712 — https://github.com/Roxas2712. LICENSE-ROXAS2712.md retains existing rights and grants Cedric / UNDERdecoded the specific incorporation permission with visible credit.