Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crystal tileset extraction currently compacts bank 1 from source tile addresses
$80–$dfto$60–$bf. This changes the public identity of those tiles even though the compact atlas itself can still render.Preserve the source VRAM bank boundary in the atlas, metatile references and decoded palette map. Add a Gen2 import marker revision to rebuild older generated assets. Single-bank and explicit attribute-bank formats keep their existing decoder. Saves and opaque mod storage are not rewritten.
Validation on this upstream-based branch: 577 synthetic extraction/layout/palette/cache-invalidation checks plus 21 adjacent Gen1 palette checks passed. No ROM, mod or derived artwork is included. Integration against a fresh private Crystal import in the development fork also matched every one of the 2,048 Johto metatile references against a Gen1 reference; that is not a full visual-parity or final-package claim. Existing persistent mod-mesh caches still need migration validation.
Original contributions by Roxas2712 are offered under
LICENSE-ROXAS2712.md, including the specific integration permission for Cedric / UNDERdecoded with visible credit. Existing authors’ rights and licenses remain in force.Composed upgrade follow-up
A separate current-fork
5dd7f527run cloned an owned pre-fix QA profile with generated ROM data and opaque mod caches, then used the normal importer and unchanged external mod. The VRAM revision updated without a blanket mod-cache reset. Natural START/options, starter acquisition and a Route29 wild command menu passed; FULL scenery drew all four near maps with zero guard fallback. Of 1,448 fresh generated Lua/PNG files, 1,447 matched byte-for-byte; the remaining maps file matched in a strict parsed-value/shared-table comparison covering 75,504 nodes. The original old profile, source mod and ROM remained unchanged. This is composed fork/internal-framebuffer evidence, not independent-branch GPU, OS-window, all-world/settings or final package acceptance.