Repository navigation
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing level-up layer stops unchanged presentation consumers at import. Add FRLG's native vertical streak artwork and queue-owned drawing, using the existing battle frame for all 18 sprite samples. Only visible active battlers receive the effect; off-screen party members, hidden/fainted actors and unsupported cartridge profiles receive no substitute artwork.
Artwork is decoded from the user's exact verified cartridge, with separate tile/palette fingerprints and checked offsets. A GBA-only profile marker refreshes the cache. The new alpha painter implements RGB555 coefficients12/6 against a snapshot of the underlying surface, retaining sibling-OAM behavior. Buffers are reused and released by native battle exit. Source wrappers borrow the native layer once with callback attribution, stale-admission rejection and graphics/error restoration.
Validation:
823bd86661passes all 21 targeted groups: existing Gen2 options/scene/menu/stack, GBA modal, command/admission/animation, text, import/cache and render checks. The final additional exit coverage is in frozen071fd20d37, with identical production source.a46f554f90and OpenGL5b10ace8f3each pass 25,658 real GPU pixel/ownership checks at DPI 1/2, including clipping, transparent pixels, saturation, repeated sibling draws and callback errors. The preserved OpenGL DPI2 counterexample is fixed by binding the original target before pop(all), so scissor restoration uses its DPI. Shader arithmetic and test tolerances remain unchanged.2f34155b59performs a full cache upgrade, writes the exact 8x16 PNG and native constant record, imports the new layer and reaches the next missingswitch_seqcontract. Output proofd0e300cb70verifies the production-written PNG and marker. The failed Card result remains preserved.Draft: complete unchanged-mod battle presentation, real gameplay level-up visual acceptance and interactive 60 FPS remain unqualified. No presentation-version capability is advertised to hide remaining contracts. Gen2 rules, input, HP, PP, RNG and saves retain their native owners.
QA enforces 20 GiB free and uses fresh disposable profiles. No player saves, ROM payload, generated artwork or private runtime is published.
Contributions by Roxas2712 — https://github.com/Roxas2712. LICENSE-ROXAS2712.md preserves the specific integration permission for Cedric / UNDERdecoded with the applicable credit requirement. Existing notices, licences and rights remain intact.
The source-facing layer composes the native session, boundary and drawing prerequisites in #329/#317. The public native diff preserves its older queue body and adds one queue gate/row type rather than copying a current-fork controller. LeafGreen registration/manifest remains in #183. The qualified public composition
57edc03055passes all 13 targeted groups, including 2,119 timeline and 85 facade checks, using those declared prerequisites. Its windowless FR/LG resource result matches the independent 128 pixel reference. No current-fork native body is overlaid.The shared native-alpha bank now accepts an optional shader program and scoped uniform setup, allowing the separately offered colour-effect interface to combine fade/mask/alpha in one painter call. Default native level-up callers retain their original program and integer operation. Fork/public composed CPU checks pass93 effect ownership checks plus2119 streak and85 facade checks; owned-output Metal/OpenGL probes pass346 checks each in both compositions, including the default alpha path. This extension does not qualify full gameplay or window/FPS acceptance.