CDA-98 Workaround to updating forecast location for a spec#1647
Open
rma-bryson wants to merge 5 commits intodevelopfrom
Open
CDA-98 Workaround to updating forecast location for a spec#1647rma-bryson wants to merge 5 commits intodevelopfrom
rma-bryson wants to merge 5 commits intodevelopfrom
Conversation
rma-bryson
changed the title
rma-bryson
force-pushed
the
bugfix/bad_forecast_spec_behavior
branch
from
3952168 to
c15971f
Compare
rma-bryson
force-pushed
the
bugfix/bad_forecast_spec_behavior
branch
from
c15971f to
eca6345
Compare
rma-bryson
changed the title
adamkorynta
reviewed
Mar 23, 2026
cwms-data-api/src/main/java/cwms/cda/data/dao/ForecastSpecDao.java
Outdated
Show resolved
Hide resolved
adamkorynta
reviewed
Mar 23, 2026
cwms-data-api/src/test/java/cwms/cda/api/ForecastSpecControllerTestIT.java
Outdated
Show resolved
Hide resolved
adamkorynta
reviewed
Mar 23, 2026
cwms-data-api/src/main/java/cwms/cda/data/dao/ForecastSpecDao.java
Outdated
Show resolved
Hide resolved
adamkorynta
reviewed
Mar 24, 2026
cwms-data-api/src/test/java/cwms/cda/api/ForecastSpecControllerTestIT.java
Outdated
Show resolved
Hide resolved
adamkorynta
requested changes
Mar 24, 2026
| }); | ||
| } | ||
|
|
||
| public void updateSpecWithLocationIdChange(ForecastSpec forecastSpec) { |
Collaborator
There was a problem hiding this comment.
This does not only update the location id, it updates all fields given your deletes and re-store call.
Additionally, if the location id is the only the thing that needs to be updated, and this is a workaround, direct table edits are much better so you can avoid such destructive calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation id, does not overwrite the original spec, but creates a new one for the new location.