CDA-105: Updated authentication error message for expired API keys#1667
Open
zack-rma wants to merge 4 commits intoUSACE:developfrom
Open
CDA-105: Updated authentication error message for expired API keys#1667zack-rma wants to merge 4 commits intoUSACE:developfrom
zack-rma wants to merge 4 commits intoUSACE:developfrom
Conversation
MikeNeilson
previously approved these changes
Apr 1, 2026
Collaborator
|
It is probably worth testing specifically that the error message for an expired key should be identical to the error message for a invalid key |
Collaborator
Author
|
Rating tests currently failing, only for latest schema. Likely introduced by merging main branch into this PR. |
Contributor
Yep, that looks like that Rating test not adding the location first, which should fail on latest if that got merged in. |
MikeNeilson
requested changes
Apr 3, 2026
| .assertThat() | ||
| .statusCode(is(HttpCode.UNAUTHORIZED.getStatus())); | ||
| .statusCode(is(HttpCode.UNAUTHORIZED.getStatus())) | ||
| .body("message", is("Authentication failed. " |
Contributor
There was a problem hiding this comment.
Okay, at this point we just just make it a public constant. Copying something this long and with separate lines is just asking for trouble.
MikeNeilson
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1554
Updates API key error message from
no user for keytoAuthentication failed. The API Key may be invalid or no longer active.