Make smartMacroDocRootPath writable before copying in doc-dev #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! |
jonhermansen
force-pushed
the
fix-doc-dev-perms-on-copy
branch
from
7db7272 to
918df05
Compare
|
Thank you for your contribution! |
For NixOS users, the destination directory here is not writable, but it should be. This was originally reported in NixOS/nixpkgs#423634 Fixes UltimateHackingKeyboard#2679
jonhermansen
force-pushed
the
fix-doc-dev-perms-on-copy
branch
from
918df05 to
e605c28
Compare
|
Thank you for your contribution! |
Contributor
Author
|
I signed the CLA and updated the commit message. Thanks for the awesome keyboard! |
Member
|
@jonhermansen Thanks for your kind words and contribution! @ert78gb will look into your PR. |
|
Is there anything we can do to help getting this integrated? |
Member
|
My latest comment in this topic #2679 (comment) please help me understand why is this PR solve the problem. I just would like to understand the root cause. What changed on nixos side, etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NixOS users, the destination directory here is not writable, but
it should be. This was originally reported in NixOS/nixpkgs#423634
Fixes #2679