Skip to content

Conversation

@ert78gb
Copy link
Member

@ert78gb ert78gb commented Dec 7, 2025

@ert78gb ert78gb force-pushed the feat-agent-fw-versions-metadata branch from 80a5295 to d1b7f21 Compare December 7, 2025 20:14
@ert78gb ert78gb marked this pull request as ready for review December 7, 2025 20:19
@mondalaci
Copy link
Member

@kareltucek Please review this one.

@kareltucek
Copy link
Collaborator

I am wondering whether last Agent-side save is actually the useful information - rather than say the version that performed the last migration.

Also, thinking about it, firmware isn't interested in these data, so I should have introduced simply a dynamic-length byte blob instead, so that Robi could save whatever info he finds useful.

Anyways, looks good to me -> feel free to merge.

@ert78gb
Copy link
Member Author

ert78gb commented Dec 8, 2025

I am wondering whether last Agent-side save is actually the useful information - rather than say the version that performed the last migration.

I thought Agent side error cloud screw up the config too.

Also, thinking about it, firmware isn't interested in these data, so I should have introduced simply a dynamic-length byte blob instead, so that Robi could save whatever info he finds useful.

Now we have 2 blob :) I am fine with these 2 info. I hope it will help in the investigations.

@mondalaci mondalaci merged commit 2a236d6 into master Dec 8, 2025
4 checks passed
@mondalaci mondalaci deleted the feat-agent-fw-versions-metadata branch December 8, 2025 18:28
@kareltucek
Copy link
Collaborator

I meant last save vs last migration, not agent vs firmware :-).

(Firmware fell out of that be ause it does not do migrations.)

@kareltucek
Copy link
Collaborator

Now we have 2 blob :)

Indeed! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants