Add host-path alias symlink startup hook and validation coverage#20
Closed
Add host-path alias symlink startup hook and validation coverage#20
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements host-path alias parity via a startup symlink strategy instead of a bind-mount alias.
What changed
.ddev/web-entrypoint.d/90-dcq-host-path-alias.sh./var/www/htmlat container startup.DCQ_HOST_PATH_ALIAS=0|false|off.install.yamlproject_filesandremoval_actions.README.md.Important fix included
Entry-point scripts are sourced by DDEV. The initial implementation used
exit, which could terminate container startup when aliasing was disabled. This PR fixes that by using safe sourced-script return behavior.Validation
Targeted bats checks pass:
path map prefers DDEV_HOST_PROJECT_ROOThost-path alias symlink is created on restarthost-path alias can be disabled via DCQ_HOST_PATH_ALIASNotes
This PR establishes the alias architecture and keeps existing path-mapping wrappers in place for safety.
A follow-up phase will investigate removing/simplifying wrapper path-mapping logic to rely on host-path parity directly.
Refs #19