Skip to content

[pull] master from DefinitelyTyped:master #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Oct 27, 2025
Merged

[pull] master from DefinitelyTyped:master #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62937f5
🤖 Merge PR #73971 feat(rails__actioncable): Add Consumer.addSubProtoc…
shunichi Oct 27, 2025
bc2419b
🤖 Update CODEOWNERS
typescript-bot Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@
/types/amqp/ @seikho @jonnysparkplugs
/types/amqp-rpc/ @wokim
/types/amqplib/ @mnahkies @abreits @nfantone @nickzelei @XVincentX @seonggwonyoon
/types/amzn__synthetics-playwright/ @kovacsandor
/types/analog-clock/ @ihatecsv
/types/analytics-node/ @fongandrew @thomasthiebaud
/types/anchor-js/ @xt0rted
Expand Down Expand Up @@ -1913,7 +1914,7 @@
/types/exit/ @Bartvds
/types/exorcist/ @TeamworkGuy2 @BendingBender
/types/expand-tilde/ @carnesen
/types/expect-cookies/ @dmurvihill
/types/expect-cookies/ @dmurvihill @gregl83
/types/expect-puppeteer/ @tkrotoff @jfm710
/types/expect.js/ @teppeis
/types/expectations/ @vvakame
Expand Down Expand Up @@ -3540,7 +3541,7 @@
/types/jalaali-js/ @alitaheri
/types/japanese-characters/ @peterblazejewicz
/types/japanese-holidays/ @syamatoo @peterblazejewicz
/types/jasmine/ @borisyankov @theodorejb @lukas-zech-software @Engineer2B @cyungmann @Roaders @devoto13 @fdim @kolodny @stephenfarrar @djungowski @chivesrs @kirjs @Semigradsky
/types/jasmine/ @borisyankov @theodorejb @lukas-zech-software @Engineer2B @cyungmann @Roaders @fdim @kolodny @stephenfarrar @djungowski @chivesrs @kirjs @Semigradsky
/types/jasmine/v1/ @borisyankov
/types/jasmine/v2/ @borisyankov @theodorejb @davidparsson @gmoothart @lukas-zech-software @Engineer2B @cyungmann @devoto13 @fdim
/types/jasmine/v3/ @borisyankov @theodorejb @davidparsson @lukas-zech-software @Engineer2B @cyungmann @Roaders @devoto13 @fdim @kolodny @stephenfarrar @djungowski @chivesrs @kirjs @Semigradsky
Expand Down Expand Up @@ -4762,7 +4763,7 @@
/types/mcping-js/ @Inrixia
/types/mcrypt/ @pluma
/types/mcustomscrollbar/ @flurg
/types/md5/ @arcdev1 @jprogrammer @peterblazejewicz @DethAriel
/types/md5/ @arcdev1 @peterblazejewicz @DethAriel
/types/mdast/ @ChristianMurphy @lujun2 @remcohaszing @wooorm @remcohaszing
/types/mdast/v3/ @ChristianMurphy @lujun2 @remcohaszing @wooorm
/types/mdns/ @reppners
Expand Down Expand Up @@ -5443,7 +5444,7 @@
/types/optimist/ @soywiz @chbrown
/types/optimize-css-assets-webpack-plugin/ @odnamrataizem @skovy
/types/oracle__oraclejet/ @nolakara @jingxwu
/types/oracledb/ @connorjayfitzgerald @dannyb648 @jacobwheale @hjamil-24 @sharadraju
/types/oracledb/ @connorjayfitzgerald @dannyb648 @jacobwheale @sudarshan12s @sharadraju
/types/oracledb/v3/ @Bigous @connorjayfitzgerald
/types/orchestrator/ @tkQubo @TeamworkGuy2
/types/orientjs/ @saeedtabrizi @aleksey-rezvov
Expand Down Expand Up @@ -6016,7 +6017,7 @@
/types/radix64/ @huan086
/types/raf/ @BenLorantfy
/types/raf-schd/ @adambrgmn
/types/rails__actioncable/ @martin-badin
/types/rails__actioncable/ @martin-badin @shunichi
/types/rails__activestorage/ @imustafin @cbothner
/types/rails__request.js/ @alexandergitter
/types/rails__ujs/ @fsubal @abcang
Expand Down Expand Up @@ -7700,7 +7701,7 @@
/types/tabulator-tables/ @jojoshua @mike-lischke
/types/tadashi__koa-jwt-authz/ @Shqrp
/types/tail/ @spacejack @devindavies
/types/tampermonkey/ @silverwzw @nikolay-borzov @taozhiyu @double-beep
/types/tampermonkey/ @silverwzw @nikolay-borzov @taozhiyu @double-beep @ziuchen
/types/tapable/ @e-cloud @johnnyreilly
/types/tapable/v0/ @e-cloud
/types/tapable/v1/ @e-cloud @johnnyreilly
Expand Down Expand Up @@ -8436,7 +8437,7 @@
/types/wordfilter/ @mlc
/types/wordpress-hash-node/ @glennreyes
/types/wordpress__admin/ @oblakstudio
/types/wordpress__block-editor/ @dsifford @sirreal @dmsnell
/types/wordpress__block-editor/ @dsifford @sirreal @dmsnell @joshualip-plaudit
/types/wordpress__block-library/ @dsifford
/types/wordpress__block-serialization-spec-parser/ @dsifford
/types/wordpress__blocks/ @dsifford @sirreal @dmsnell @tomasztunik @sunyatasattva @bastolen
Expand Down
2 changes: 2 additions & 0 deletions types/rails__actioncable/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ export const adapters: {
*/
export class Consumer {
readonly subscriptions: Subscriptions;
readonly subprotocols: string[];

constructor(url: string);
get url(): string;
connect(): boolean;
disconnect(): void;
addSubProtocol(protocol: string): void;
}

export interface BaseMixin {
Expand Down
2 changes: 2 additions & 0 deletions types/rails__actioncable/rails__actioncable-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ const consumer = createConsumer("url"); // $ExpectType Consumer
createConsumer(() => "url"); // $ExpectType Consumer

consumer.url; // $ExpectType string
consumer.subprotocols; // $ExpectType string[]

consumer.connect(); // $ExpectType boolean
consumer.disconnect(); // $ExpectType void
consumer.addSubProtocol("custom-protocol"); // $ExpectType void

{
const subscription = consumer.subscriptions.create(
Expand Down