Skip to content

[pull] master from DefinitelyTyped:master #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Dec 21, 2025
Merged

[pull] master from DefinitelyTyped:master #1540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45ba95
🤖 Merge PR #74155 [@types/plotly.js] Add `zorder` property to PlotDat…
ryan-williams Dec 20, 2025
6dc2213
🤖 Merge PR #74246 [tabulator-tables] align validator and EditorParams…
Trash0101 Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/plotly.js/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,6 +1684,7 @@ export interface PlotData {
zsmooth: "fast" | "best" | false;
zmin: number;
zmax: number;
zorder: number;
ygap: number;
xgap: number;
transpose: boolean;
Expand Down
13 changes: 10 additions & 3 deletions types/tabulator-tables/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,14 @@ export interface ColumnDefinition extends ColumnLayout, CellCallbacks {
*
* Validators can be applied by using the validator property in a columns definition object (see Define Columns for more details).
*/
validator?: StandardValidatorType | StandardValidatorType[] | Validator | Validator[] | string | undefined;
validator?:
| StandardValidatorType
| StandardValidatorType[]
| Validator
| Validator[]
| string
| undefined
| ((cell: CellComponent, value: any) => boolean);

/**
* Mutators are used to alter data as it is parsed into For example if you wanted to convert a numeric column into a boolean based on its value, before the data is used to build the table.
Expand Down Expand Up @@ -1657,7 +1664,7 @@ export type Editor =
onRendered: EmptyCallback,
success: ValueBooleanCallback,
cancel: ValueVoidCallback,
editorParams: {},
editorParams: Record<string, unknown>,
) => HTMLElement | false);

export type EditorParams =
Expand All @@ -1669,7 +1676,7 @@ export type EditorParams =
| DateParams
| TimeParams
| DateTimeEditorParams
| ((cell: CellComponent) => {});
| ((cell: CellComponent) => Record<string, unknown>);

export type ScrollToRowPosition = "top" | "center" | "bottom" | "nearest";
export type PopupPosition = ColumnDefinitionAlign | "top" | "bottom";
Expand Down
1 change: 1 addition & 0 deletions types/tabulator-tables/tabulator-tables-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ colDef.validator = {
};
colDef.validator = "float";
colDef.validator = { type: "float", parameters: {} };
colDef.validator = (cell, value) => true;

let validators: Validator[] = [
{ type: "integer", parameters: {} },
Expand Down