Re-arrange private METAR parser #3942
Merged
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Maintenance
dopplershift
force-pushed
the
move-parser
branch
from
6eb9721 to
8d18152
Compare
dcamron
approved these changes
Dec 23, 2025
This puts the grammar and Makefile to the tools folder so they're not included in the wheels we ship. Also build up the Makefile a bit to encode how to install canopy.
Replace private subpackage with a private module since we moved everything else out of that private directory.
dopplershift
force-pushed
the
move-parser
branch
from
8d18152 to
cc15f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Makefiletotools/so that we don't include them in the wheels we shipMakefileand include details for installing canopyio/_metar_parser/metar_parser.pytoio/_metar_parser.pysince there was only one file in that private subpackage. A private module is a simpler layout.I tried regenerating the parser with canopy, but the latest version (now 0.4.1) produces no differences.