Add agent desktop screen clipboard gates#2589
Open
IvanchitorJR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
agent-securitySkill path:
skills/ai-security/agent-security/Related review issue: #2452.
What Was Wrong
The
agent-securityskill already covers tool permissions, least privilege, human approval gates, blast radius, audit trails, rollback, and multi-agent trust boundaries. It did not explicitly treat desktop observation primitives as cross-application data sources.That can create both false positives and missed findings:
What This PR Fixes
agent-securityto1.0.3.Desktop Observation and Clipboard Boundary Reviewstep covering window/monitor scope, sensitive-screen handling, clipboard provenance, browser profile separation, external send gates, and retention.AGENT-DESK-01throughAGENT-DESK-07.Desktop Observation / Clipboardposture and a dedicated control-evidence table.Evidence
Before:
A reviewer could see
screenshot,click, orclipboard_readand classify the agent as broadly unsafe without checking whether those tools were constrained to a staging window, redacted, and approval-gated. Conversely, full-screen OCR plus silent clipboard reads could be missed because the skill focused on file, network, database, and registered tool access.After:
The skill now requires reviewers to record screen scope, OCR/sensitive-screen handling, clipboard controls, browser profile separation, external transfer gates, and retention before scoring desktop automation risk.
Test Cases Added/Updated
skills/ai-security/agent-security/tests/benign/desktop-qa-window-scoped-clipboard.jsonskills/ai-security/agent-security/tests/vulnerable/fullscreen-ocr-clipboard-exfiltration.jsonValidation
git diff --checkgit diff --cached --checkskills/**/SKILL.mdandroles/**/SKILL.mdindex.yamlreferenced path existence checkskills/ai-security/agent-security/SKILL.mdDesktop Observation and Clipboard Boundary Review,AGENT-DESK-01throughAGENT-DESK-07, output table, and version historyDuplicate Check
Checked open and closed PRs for:
agent-security+ desktop automation / screen / clipboard evidence gatesagent-security+ screenshot / OCR / clipboard / GUI automationdesktop QA assistant/ window-scoped clipboardI did not find an existing PR implementing the desktop observation and clipboard boundary review requested by #2452.
Bounty Tier
Bounty Info
CONTRIBUTING.mdbounty terms