Fix linkage with a system libatomic_ops shared library#61
Open
ffontaine wants to merge 1 commit intoUnity-Technologies:unity-masterfrom
Open
Fix linkage with a system libatomic_ops shared library#61ffontaine wants to merge 1 commit intoUnity-Technologies:unity-masterfrom
ffontaine wants to merge 1 commit intoUnity-Technologies:unity-masterfrom
Conversation
Issue bdwgc#247 (bdwgc). When bdwgc is linked with the external libatomic_ops, bdw-gc.pc must contain the needed dynamic libraries (such as -latomic_ops) otherwise build of applications could fail on the link stage on some hosts: * libgc.so: undefined reference to 'AO_fetch_compare_and_swap_emulation' * libgc.so: undefined reference to 'AO_store_full_emulation' So, this commit sets ATOMIC_OPS_LIBS to "-latomic_ops" when a system atomic_ops library is used and uses ATOMIC_OPS_LIBS in bdw-gc.pc.in. * bdw-gc.pc.in (Libs): Add @ATOMIC_OPS_LIBS@. * configure.ac [$with_libatomic_ops!=no && $with_libatomic_ops!=none && $THREADS!=none] (ATOMIC_OPS_LIBS): Set to -latomic_ops; do AC_SUBST. [Retrieved from: bdwgc@02a44ee] Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Author
|
Do you have some comments on this PR opened nearly one year ago? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue bdwgc#247 (bdwgc).
When bdwgc is linked with the external libatomic_ops, bdw-gc.pc must
contain the needed dynamic libraries (such as -latomic_ops) otherwise
build of applications could fail on the link stage on some hosts:
So, this commit sets ATOMIC_OPS_LIBS to "-latomic_ops" when a system
atomic_ops library is used and uses ATOMIC_OPS_LIBS in bdw-gc.pc.in.
&& $THREADS!=none] (ATOMIC_OPS_LIBS): Set to -latomic_ops; do AC_SUBST.
[Retrieved from:
https://github.com/ivmai/bdwgc/commit/02a44ee1df8176c72e75fd706d1a8f063d3196d5]
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com