Skip to content

Recognize and support OpenBSD/arm64#62

Open
bluerise wants to merge 1 commit intoUnity-Technologies:unity-masterfrom
bluerise:obsd
Open

Recognize and support OpenBSD/arm64#62
bluerise wants to merge 1 commit intoUnity-Technologies:unity-masterfrom
bluerise:obsd

Conversation

@bluerise
Copy link
Copy Markdown

No description provided.

@bluerise
Copy link
Copy Markdown
Author

Alternatively, it looks like you could just cherry-pick this patch from upstream:

bdwgc@c94e4d9

@joncham
Copy link
Copy Markdown
Member

joncham commented May 25, 2021

Hello @bluerise wondering if you hit any issues related to this in Unity? I'm wondering about the motivation for the PR to our fork? Thanks!

@bluerise
Copy link
Copy Markdown
Author

Hi @joncham!

My initial motivation was to make Mono ( https://www.mono-project.com ) work on an arm64-based OpenBSD machine.

Mono uses Unity's fork of bdwgc instead of the Upstream version: mono/mono@cc13723

So, to make Mono work and compile on arm64, so I can play OpenRA, I would like to have this patch in Unity's fork of bdwgc, so that I can then tell the Mono project to update the git reference/submodule to include a newer version of Unity's fork.

Basically, it only is related to Unity in that Mono, which is unrelated to you I guess, depends on your fork. :)

The patchset adds support that bdwgc compiles and works on OpenBSD/arm64. Sorry that I haven't stated that in the initial Pull Request. At that time I thought this project was part of Mono, so I had the information combined here: mono/mono#21015

The patchset doesn't change anything else, and hence does not cause regressions elsewhere, it just adds a new platform.

As per my comment before, apparently the Upstream version already received (about the same) change already, so the easiest way might be to just cherry-pick that change from them.

While this does not provide much improvement for Unity's projects, I'd be really happy to have this in so that Mono can gain official support for OpenBSD/arm64.

Thanks,
Patrick

monojenkins pushed a commit to monojenkins/runtime that referenced this pull request May 25, 2021
There are three changes required to build mono on OpenBSD/arm64.

- The first one is to provide the UCONTEXT macros, which for OpenBSD simply map to sigcontext.
- Furthermore as stated in issue mono/mono#21005, mono/boringssl@mono...bluerise:obsd is necessary for boringssl so that it can be built.
- And last, bdwgc needs to be patches as well: Unity-Technologies/bdwgc#62
vargaz pushed a commit to dotnet/runtime that referenced this pull request May 25, 2021
There are three changes required to build mono on OpenBSD/arm64.

- The first one is to provide the UCONTEXT macros, which for OpenBSD simply map to sigcontext.
- Furthermore as stated in issue mono/mono#21005, mono/boringssl@mono...bluerise:obsd is necessary for boringssl so that it can be built.
- And last, bdwgc needs to be patches as well: Unity-Technologies/bdwgc#62

Co-authored-by: bluerise <bluerise@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants