Skip to content

fix!: Update validation test to follow documentation.#19

Open
semenovm wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
semenovm:validation_tests
Open

fix!: Update validation test to follow documentation.#19
semenovm wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
semenovm:validation_tests

Conversation

@semenovm

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected, including removal of schema files
    or fields
    )
  • Documentation update

Is this a Breaking Change or Removal?

If you checked "Breaking change" above, or if you are removing any schema
files or fields:

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

Breaking Changes / Removal Justification

This change makes python and likely ts example to fail validation tests.
This change makes tests follow the protocol documentation and spec, python implementation is incorrect and must be updated to pass the new test.


Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Update validation tests to:

  1. Expect soft-fail when supported following https://ucp.dev/specification/checkout/#error-handling
  2. Use correct error message format for hard fails https://ucp.dev/specification/checkout-rest/#error-responses

@semenovm
semenovm requested a review from a team January 23, 2026 13:59
@semenovm
semenovm force-pushed the validation_tests branch 2 times, most recently from c026b2c to d47cfa1 Compare January 23, 2026 19:33
@nearlyforget
nearlyforget requested a review from a team February 28, 2026 04:10
@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days status:under-review and removed status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days labels Jul 7, 2026
@damaz91
damaz91 requested review from damaz91 and removed request for a team July 13, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants