Skip to content

fix: update conformance tests to expect UCP version 2026-04-08#56

Merged
damaz91 merged 1 commit into
mainfrom
update-version-2026-04-08
Jul 13, 2026
Merged

fix: update conformance tests to expect UCP version 2026-04-08#56
damaz91 merged 1 commit into
mainfrom
update-version-2026-04-08

Conversation

@damaz91

@damaz91 damaz91 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

Update hardcoded version expectations in conformance tests to match the updated server version 2026-04-08.

Category (Required)

Please select one or more categories that apply to this change.

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Related Issues

Fits with samples PR: Universal-Commerce-Protocol/samples#129

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

Screenshots / Logs (if applicable)

Update hardcoded version expectations in conformance tests to match
the updated server version 2026-04-08.

TAG=agy
CONV=c03c5438-5e14-414a-9404-e0f2bdbe433c
@damaz91 damaz91 added the status:needs-triage Signal that the PR is ready for human triage label Jul 13, 2026
@damaz91
damaz91 merged commit 1d7f710 into main Jul 13, 2026
26 checks passed
@damaz91
damaz91 deleted the update-version-2026-04-08 branch July 13, 2026 12:02
segiodongo pushed a commit to segiodongo/conformance that referenced this pull request Jul 16, 2026
…rsal-Commerce-Protocol#56)

Update hardcoded version expectations in conformance tests to match
the updated server version 2026-04-08.
damaz91 added a commit that referenced this pull request Jul 17, 2026
…#51)

* fix: update conformance tests to expect UCP version 2026-04-08 (#56)

Update hardcoded version expectations in conformance tests to match
the updated server version 2026-04-08.

* fix: resolve type alias instantiation error and decouple test fixtures

- Replace FulfillmentDestinationCreateRequest instantiation with ShippingDestination to resolve TypeAliasType instantiation error.
- Decouple new test fixtures and shipping locations from conformance_input.json to a new test_fixtures.json file.
- Add --fixture_config flag to allow passing custom test fixtures.
- Update README with instructions for the new flag.

* fix: support integer inputs for major-unit price parsing

Update get_test_price() to treat both int and float major-unit inputs uniformly when converting to minor units.

---------

Co-authored-by: Federico D'Amato <damaz@google.com>
Co-authored-by: damaz91 <federico.damato91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:needs-triage Signal that the PR is ready for human triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants