fix: accept valid repeated checkout cancellation responses#57
Merged
damaz91 merged 1 commit intoJul 15, 2026
Merged
Conversation
ShuoRen-TT
marked this pull request as ready for review
July 14, 2026 21:09
damaz91
approved these changes
Jul 15, 2026
nicholasjameshall
approved these changes
Jul 15, 2026
| ) | ||
| self.assertNotEqual( | ||
|
|
||
| if response.status_code == 200: |
There was a problem hiding this comment.
nit: afaik there should be a standard library in Python for these errors
Contributor
Author
There was a problem hiding this comment.
Thank you for the suggestion and for reviewing this! You are right that http.HTTPStatus.OK would be clearer than the literal 200. For the 4xx range, the repository supports Python 3.10, while HTTPStatus.is_client_error is only available from Python 3.12, so the compatible cleanup would be to use HTTPStatus.OK together with httpx.Response.is_client_error. I will keep that pattern in mind when the suite status assertions are consolidated. I really appreciate you pointing this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #54 by updating the repeated checkout cancellation conformance test to accept both protocol-compatible outcomes:
canceledstate, for implementations that treat cancellation as an idempotent operationThe previous assertion rejected every 200 response while accidentally allowing redirects and server errors. The revised test validates the returned checkout when cancellation succeeds and limits error responses to the 4xx range.
Fixes #54.
Validation
checkout_lifecycle_test.pyagainst the latest Flower Shop sample server200 + canceledis accepted503are rejectedgit diff --checkType of change
Is this a Breaking Change or Removal?
No.
Breaking Changes / Removal Justification
Not applicable.
Checklist
Pull Request Title
This PR uses the required Conventional Commits format.