ci: build and test Node.js sample#126
Merged
damaz91 merged 1 commit intoJul 16, 2026
Merged
Conversation
ShuoRen-TT
marked this pull request as ready for review
July 9, 2026 23:09
vishkaty
pushed a commit
to vishkaty/samples
that referenced
this pull request
Jul 9, 2026
Path-filter push/pull_request triggers to rest/python/** and the workflow file itself, matching the path-filtered shape of the Node.js workflow proposed in Universal-Commerce-Protocol#126, so unrelated changes do not spend CI minutes booting the Python server.
Contributor
vishkaty
pushed a commit
to vishkaty/samples
that referenced
this pull request
Jul 13, 2026
Path-filter push/pull_request triggers to rest/python/** and the workflow file itself, matching the path-filtered shape of the Node.js workflow proposed in Universal-Commerce-Protocol#126, so unrelated changes do not spend CI minutes booting the Python server.
vishkaty
pushed a commit
to vishkaty/samples
that referenced
this pull request
Jul 15, 2026
Path-filter push/pull_request triggers to rest/python/** and the workflow file itself, matching the path-filtered shape of the Node.js workflow proposed in Universal-Commerce-Protocol#126, so unrelated changes do not spend CI minutes booting the Python server.
ShuoRen-TT
force-pushed
the
agent/nodejs-build-test-ci
branch
from
July 16, 2026 07:02
29a09bd to
0bcc1f2
Compare
Contributor
Author
|
Thanks for taking another look at this. #123 and #125 have now merged. I rebased this PR onto the latest
The PR remains scoped to When convenient, could a maintainer please approve those workflow runs and review the PR for the required governance approval? Thank you! |
damaz91
approved these changes
Jul 16, 2026
nicholasjameshall
approved these changes
Jul 16, 2026
damaz91
added a commit
that referenced
this pull request
Jul 16, 2026
* ci: add Python server integration-test and happy-path workflow * ci: scope the Python server workflow to rest/python changes Path-filter push/pull_request triggers to rest/python/** and the workflow file itself, matching the path-filtered shape of the Node.js workflow proposed in #126, so unrelated changes do not spend CI minutes booting the Python server. * ci: install ucp-sdk from pip in the Python server workflow Follows samples#131: the server's pyproject now resolves ucp-sdk from pip, so the workflow no longer checks out the python-sdk repo (and no longer needs the nested checkout path that made the editable ../python-sdk reference work). CI exercises the same released SDK a user installs; catching SDK-main drift is python-sdk CI's job, not this workflow's. * refactor(client): return non-zero exit code on failure in happy-path client This allows the CI workflow to rely on the exit status of the client instead of grepping the logs for success. Simplified the workflow step accordingly. --------- Co-authored-by: Vishal Katyal <vishal@katyal.ai> Co-authored-by: vishkaty <vishkaty@users.noreply.github.com> Co-authored-by: damaz91 <federico.damato91@gmail.com> Co-authored-by: Federico D'Amato <damaz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm cinpm run buildto passnpm test --if-presentso current and future Node tests are coveredWhy
The repository currently runs pre-commit checks but does not compile or test
rest/nodejs. As a result, strict TypeScript errors in the Node.js sample remained undetected across dependency updates.This workflow adds a focused build gate for changes under
rest/nodejs/**without adding work to unrelated sample PRs.Validation
npm ci: passed, 0 vulnerabilitiesnpm run build: passednpm test --if-present: passed, 3/3 testsDependencies
This draft depends on #123 and #125. The new build job is expected to fail against the current
mainbranch until both existing Node.js compile failures are merged. The workflow deliberately does not usecontinue-on-error; after those dependencies land, it becomes the regression gate that prevents the same drift from recurring.