fix: update server to match SDK type alias changes#127
Merged
Conversation
Contributor
|
Verified this branch locally against python-sdk main ( |
ptiper
approved these changes
Jul 13, 2026
nicholasjameshall
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the sample Flower Shop merchant server to be compatible with the breaking changes in the Python SDK (which avoids
RootModelin favor of type aliases).Specifically, it:
.rootaccesses onFulfillmentandFulfillmentDestinationinstances.Fulfillment(aliased asFulfillmentWrapper),FulfillmentDestination, andVersionconstructors.city->address_locality,region->address_region) to match the new SDK models.These changes are required to fix conformance test failures when running against the new SDK.
Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Related to conformance PR Universal-Commerce-Protocol/conformance#50
Checklist
!for breaking changes).