docs(discount): document usage-limit and stacking-conflict rejection codes#577
Open
prateek-ct wants to merge 2 commits into
Open
docs(discount): document usage-limit and stacking-conflict rejection codes#577prateek-ct wants to merge 2 commits into
prateek-ct wants to merge 2 commits into
Conversation
…codes The documented discount_code_* rejection codes have no entry for two common real-world cases: a code whose overall usage allowance has been exhausted, and a code that matched and was valid but lost to stacking or best-deal resolution against an already-active discount. Both currently have to be forced into discount_code_already_applied or discount_code_combination_disallowed, which mean something narrower and would mislead a buyer. Adds discount_code_usage_limit_reached and discount_code_stacking_conflict to the error-code table, with a short note distinguishing each from its nearest existing neighbor.
prateek-ct
changed the title
damaz91
added
status:needs-triage
markdownlint (MD060/table-column-style) flagged the two new rows added in the previous commit for not aligning with the rest of the table. Re-padded every row to a consistent column width. No content change.
damaz91
added
status:needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The discount extension's rejection-code table doesn't have an entry for two common cases: a code whose overall usage allowance has been exhausted, and a code that matched and was valid but lost to stacking/best-deal resolution against an already-active discount. Both currently have to be forced into
discount_code_already_appliedordiscount_code_combination_disallowed, which mean something narrower and would actively mislead a buyer — "already applied" implies the buyer duplicated their own action, not that a promotion's usage cap ran out elsewhere.Adds
discount_code_usage_limit_reachedanddiscount_code_stacking_conflictto the documented error-code table, with a short note distinguishing each from its nearest existing neighbor.discount_code_*values are a documented convention rather than a schema enum (seeerror_code.json), so this is a documentation-only change — no schema files touched.Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
None.
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
N/A — documentation change only.