docs: add description for catalog fulfillment property#588
Closed
carolinerg1 wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
carolinerg1
force-pushed
the
fix/catalog-fulfillment-description
branch
from
July 15, 2026 20:48
f568ccb to
04e7994
Compare
Contributor
|
Great catch @carolinerg1 ! This table is indeed rendered poorly. I found out that's not caused by something missing in the schema, but rather in the table rendering macro called in the wrong way. Current: {{ extension_fields('fulfillment', 'fulfillment') }} Correct: {{ extension_fields('fulfillment', 'checkout') }} Opened #592 to fix. Thanks again! |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds an explicit "description" to the Fulfillment property in "source/schemas/shopping/fulfillment.json" under "$defs.fulfillment_variant" and "$defs.fulfillment_lookup_variant".
Fixes an issue where the Properties table in the Fulfillment Extension specification (docs/specification/fulfillment.md), rendered dynamically via the
{{ extension_fields(...) }}macro, displayed a blank description for thefulfillmentproperty (Catalog Fulfillment).Changes
source/schemas/shopping/fulfillment.json:"description": "Fulfillment options and availability for this variant."toproperties.fulfillmentwithinfulfillment_variant."description": "Fulfillment options and availability for this variant."toproperties.fulfillmentwithinfulfillment_lookup_variant.Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
Current Fulfillment with blank description:

Updated Fulfillment with a detailed description:
