Do not attempt to hide/show cursor if a user asked for no ANSI trickery - #481
Open
Bodigrim wants to merge 1 commit into
Open
Do not attempt to hide/show cursor if a user asked for no ANSI trickery#481Bodigrim wants to merge 1 commit into
Bodigrim wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in #480.
I was surprised that
tastykeeps hiding/showing cursor even if user passed--ansi-tricks=false. I think we should guard all shenanigans with ANSI escape sequences behind--ansi-trickscheck.