fix(terminal): don't ssh-wrap the local runner's own tmux attach#264
Closed
dkrattiger wants to merge 1 commit into
Closed
fix(terminal): don't ssh-wrap the local runner's own tmux attach#264dkrattiger wants to merge 1 commit into
dkrattiger wants to merge 1 commit into
Conversation
The local runner registers its own hostname as runner_host (ADR 0013 §6), which switch_to forwarded unchecked — every `t` press ssh-wrapped a same-machine tmux attach (`ssh -t <own-host> tmux ...`). run_console_local's attach swallows failures, so a slow/flaky loopback ssh silently no-op'd, requiring repeated `t` presses. switch_to now only treats host as remote when it differs from the console's own hostname. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
I suppose this was fixed in #257? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes "task entry requires multiple
tpresses": the local runner registers its own hostname asrunner_host(ADR 0013 §6), and the dashboard'sthook forwarded it unchecked. Every attach got ssh-wrapped (ssh -t <own-host> tmux ...) even for a same-machine task, andrun_console_local's attach swallows failures — so a slow/flaky loopback ssh silently no-op'd, requiring repeatedtpresses to eventually succeed.switch_to(src/panopticon/terminal/console.py) now only treatshostas remote when it differs from the console's own hostname (local_host, injectable for tests), matching ADR 0013 §7's intended "not the local machine" check, which had never been implemented.See the plan artifact (
plan.md) on this task for the full root-cause analysis.src/panopticon/terminal/console.py—switch_togains alocal_hostparam; dropshosttoNonewhen it equals the local machine's hostname.tests/test_console.py— covers the local (own-hostname) and remote (differing-hostname) cases explicitly.