test(sessionservice): pin the --host default/env/flag behavior for local runners#265
Merged
Merged
Conversation
The host daemon's --host default fell back to socket.gethostname() when neither --host nor PANOPTICON_RUNNER_HOST was set, so every runner -- including a purely local one -- registered a truthy host. The terminal supervisor treats any truthy runner_host as remote and wraps tmux attach in `ssh -t <host>`, which breaks attach for local-only setups. Default to None instead, matching the None-is-local contract the rest of the chain (attach_command, the dashboard, the switch-file) already expects. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…runner-host-default # Conflicts: # src/panopticon/sessionservice/host.py
dkrattiger
marked this pull request as ready for review
July 9, 2026 21:39
tildesrc
approved these changes
Jul 9, 2026
…runner-host-default # Conflicts: # src/panopticon/sessionservice/host.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host.py's--hostCLI default falling back tosocket.gethostname(), which the terminal supervisor'sattach_command()treats as "remote" and wraps inssh -t <host>, breaking local tmux attach.mainin fix(sessionservice): default --host to "" so local runner doesn't SSH-wrap attaches #257 (default--hostto""instead of the local hostname) — that PR shipped with no regression test for the default itself.build_arg_parser()out ofmain()(which is# pragma: no cover, endless-loop wiring) so the parser can be built and inspected without running the daemon, then pins three cases — no env/flag set →host == "",PANOPTICON_RUNNER_HOSTset → used, and--hostflag overrides the env var.Full root-cause writeup is in the plan artifact (
plan.md) on this task.🤖 Generated with Claude Code