feat(sessionservice): surface container exit reason in reconcile#271
Open
tildesrc wants to merge 1 commit into
Open
feat(sessionservice): surface container exit reason in reconcile#271tildesrc wants to merge 1 commit into
tildesrc wants to merge 1 commit into
Conversation
When a container exits non-zero before registering (e.g. docker-in-docker timeout, broken image layer), reconcile() now calls get_container_failure() on the runner and reports FAILED with the exit code + last 20 log lines instead of silently composing `down` with no context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_container_failure(task_id)toLocalRunner: usesdocker inspectto read the exit code anddocker logs --tail 20to capture recent output, returning a human-readable detail string when the container exited non-zero,Noneotherwise.get_container_failureon theRunnerABC soStubRunnerand other backends need no changes.reconcile()inSpawner: when a claimed in-flight container is gone, checksget_container_failurefirst — reportsFAILEDwith the detail if the exit was non-zero, falls back toclear_lifecycle(→down) for a clean exit or already-removed container.test_local_runner.pycases for the docker command sequence and return values; two newtest_spawner.pyreconcile cases for the FAILED vs clear-lifecycle branches.🤖 Generated with Claude Code