refactor(sessionservice): delete superseded ProvisionDaemon#305
Open
tildesrc wants to merge 3 commits into
Open
refactor(sessionservice): delete superseded ProvisionDaemon#305tildesrc wants to merge 3 commits into
tildesrc wants to merge 3 commits into
Conversation
…on owns the loop) daemon.py and its 200-LOC test file are removed — their logic duplicated HostDaemon.run/tick near line-for-line (since tracking, versioned feed, per-task error isolation). The one real consumer, test_provisioning_acceptance.py, is rewired to call Provisioner.provision directly, preserving the real-git end-to-end property. Two docstrings and AGENTS.md are updated to name HostDaemon instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daemon.py(144 LOC) andtests/test_daemon.py(200 LOC) —ProvisionDaemon's loop logic duplicatedHostDaemon.run/ticknear line-for-line (since tracking, versioned feed, per-task error isolation) and has been superseded since commitf8eeece.test_provisioning_acceptance.pyto callProvisioner.provisiondirectly, preserving the real-git end-to-end acceptance property unchanged.spawner.py,provisioner.py) andAGENTS.mdto nameHostDaemoninstead ofProvisionDaemon; also removes the staleprefill.py/test_prefill.pyentries fromAGENTS.md(those modules were deleted in a prior commit).🤖 Generated with Claude Code