Repository navigation
Fix Lottie paint order (#9); smoother skeleton drawing and bone handles - #10
Merged
Merged
Conversation
…ible; keep Bone tool active; scale bone grab zones Lottie draws a group's first style on top while Rive draws a shape's first paint underneath, so convertLottie now creates paints in reverse (fixes #9). Bone tool stays active after each bone so chains can be drawn tip to tip. Bone tip/base grab radius shrinks for short (zoomed-out) bones so the shaft can still be rotated. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #9.
convertLottiekept list order, so a stroke listed before its fill was covered. Paints are now created in reverse (packages/lottie/src/convert.ts). Newscripts/lottie-paint-order.test.ts(part oftest:lottie) fails without the fix.Esc/Vexits). Previously it reverted to Select after every bone.boneEditing.ts), with a new bone-editor scenario (28 total).How to test
bun run test:lottieandbun scripts/bone-editor.test.ts.B, drag bone after bone from each tip; zoom out and rotate a short bone by its shaft.Screenshots / recording
Verified interactively in the browser (chain drawing, move, rotate, tip edit, one undo step each); no screenshots attached.
Checklist
check-types, lint on changed files and the Lottie/bone tests passrigging.test.tsrender step andbone-browser.test.ts(need Playwright Chromium); Lottie corpus (needs fixtures)docs/user-guide.md)