fix: move return None in luxminer _get_mac and _get_hashrate#410
Open
wilfredallyn wants to merge 1 commit intoUpstreamData:masterfrom
Open
fix: move return None in luxminer _get_mac and _get_hashrate#410wilfredallyn wants to merge 1 commit intoUpstreamData:masterfrom
return None in luxminer _get_mac and _get_hashrate#410wilfredallyn wants to merge 1 commit intoUpstreamData:masterfrom
Conversation
wilfredallyn
force-pushed
the
fix/luxminer-dead-code
branch
from
d4b76b0 to
34a3e21
Compare
wilfredallyn
changed the title
return None from luxminer _get_mac and _get_hashratereturn None in luxminer _get_mac and _get_hashrate
Remove erroneous 'return None' statements placed outside except blocks, making all subsequent logic unreachable. Same pattern was already fixed for _get_wattage in 63bf0cd.
wilfredallyn
force-pushed
the
fix/luxminer-dead-code
branch
from
34a3e21 to
c8781f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using home assistant and hass-miner, I was getting incorrect hashrate readings which led to me finding 'return None' statements making code unreachable. This is the same fix for
_get_wattagein 63bf0cd.