Increase speed/performance by roughly 10%#3
Open
bandjhughes wants to merge 2 commits intoUrbsLab:masterfrom
Open
Increase speed/performance by roughly 10%#3bandjhughes wants to merge 2 commits intoUrbsLab:masterfrom
bandjhughes wants to merge 2 commits intoUrbsLab:masterfrom
Conversation
use list comprehension DRY refactor Use enumerate Reverse order in if statement to avoid math when possible Remove unnecessary assignment Remove unnecessary cast (when more efficient) Remove unnecessary elif statement Remove unnecessary variables passed to functions
Author
|
No changes to functionality (at least not intentionally), just minor changes to improve runtime speed. Before changes were made, the random seed was set, and a (repeatable) confusion matrix was generated for a multi-class classifier as a baseline. After the changes, the exact same confusion matrix is still produced, and the average runtime is reduced around 9-10 percent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use list comprehension
DRY refactor
Use enumerate
Reverse order in if statement to avoid math when possible
Remove unnecessary assignment
Remove unnecessary cast (when more efficient)
Remove unnecessary elif statement
Remove unnecessary variables passed to functions