GitHub actions workflow#147
Open
gloskull wants to merge 2 commits into
Open
Conversation
…actions-workflow Optimize frontend GitHub Actions parallelization
Contributor
|
resolve conflicts @gloskull |
3 similar comments
Contributor
|
resolve conflicts @gloskull |
Contributor
|
resolve conflicts @gloskull |
Contributor
|
resolve conflicts @gloskull |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce CI runtime and wasted runner time by parallelizing frontend checks and sharding long-running tests.
Harden workflows with concurrency cancellation, least-privilege permissions and job timeouts to improve CI reliability.
Fix existing lint/test regressions that prevented a green CI run.
Description
Split .github/workflows/frontend-ci.yml into independent lint, typecheck, unit-tests, build, and sharded e2e-tests jobs, added a ci-complete aggregation job, plus concurrency, job timeout-minutes, and permissions settings.
Touched .github/workflows/visual-regression.yml to add concurrency, explicit permissions, a timeout-minutes, and limited Playwright workers with --workers=50%.
Fixed heatmap wiring in src/components/map/AssetHeatmapLayer.tsx by calling the onTileUpdate callback and adding it to the effect dependency list, and removed an unused import.
Normalized tile key formatting in src/components/map/boundaryManager.ts from layer::x,y to layer:x:y.
Fixed sha256Hex in src/services/keyCache.ts by normalizing input bytes (new Uint8Array(bytes)) before calling crypto.subtle.digest to avoid runtime errors in tests.
Testing
Parsed workflows with Ruby/YAML to validate outputs via ruby -e "require 'yaml'; Dir['.github/workflows/*.yml'].each { |f| YAML.load_file(f); puts "parsed #{f}" }" which succeeded.
Ran static checks: npm run lint and npx tsc --noEmit, both succeeded after fixes.
Ran unit/component and integration tests with npm run test, all tests passed (547 tests passed).
Attempted npm run build but the Next.js production build failed in this environment due to inability to fetch Google Fonts from fonts.googleapis.com, so build steps should be re-run in CI or an environment with network access to Google Fonts.
Closes #128