Skip to content

[k2] improve runtime-config argument processing#1606

Open
apolyakov wants to merge 1 commit intomasterfrom
apolyakov/k2-error-on-runtime-config-load-failure
Open

[k2] improve runtime-config argument processing#1606
apolyakov wants to merge 1 commit intomasterfrom
apolyakov/k2-error-on-runtime-config-load-failure

Conversation

@apolyakov
Copy link
Copy Markdown
Contributor

@apolyakov apolyakov commented Apr 10, 2026

  • use mmap instead of read
  • throw an error instead of warning since we don't want to run without successfully loaded runtime config if it was specified as an argument

@apolyakov apolyakov added this to the next milestone Apr 10, 2026
@apolyakov apolyakov self-assigned this Apr 10, 2026
@apolyakov apolyakov added runtime Feature related to runtime k2 Affects compiler or runtime in K2 mode labels Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shamzik Shamzik Shamzik approved these changes

@PetrShumilov PetrShumilov Awaiting requested review from PetrShumilov

@denisichh denisichh Awaiting requested review from denisichh

Assignees

@apolyakov apolyakov

Labels

k2 Affects compiler or runtime in K2 mode runtime Feature related to runtime

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

2 participants

@apolyakov @Shamzik